Skip to content

[HttpClient] Documented the cancel() method #11663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

[HttpClient] Documented the cancel() method #11663

merged 1 commit into from
Jun 5, 2019

Conversation

javiereguiluz
Copy link
Member

Fixes #11658.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Jun 4, 2019
@OskarStark
Copy link
Contributor

Thanks Javier.

@OskarStark OskarStark merged commit a983ece into symfony:4.4 Jun 5, 2019
OskarStark added a commit that referenced this pull request Jun 5, 2019
@OskarStark
minor #11663 [HttpClient] Documented the cancel() method (javiereguiluz)
ea04279 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Documented the cancel() method

Fixes #11658.

Commits
-------

a983ece [HttpClient] Documented the cancel() method
@nicolas-grekas nicolas-grekas mentioned this pull request Jun 5, 2019
Merged
@javiereguiluz
Copy link
Member Author

I was going to put this "on hold", but you were too fast merging it. No worries!!! But when we merge #11668 we'll need to revert all this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
HttpClient Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @OskarStark @carsonbot